Repository navigation
API: Preserve float comparisons with wide literals - #18980
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
Keep ordering predicates over float columns when a double bound exceeds the finite float range. These predicates still need to distinguish infinite and NaN values. Preserve double infinities during conversion to float so equality and set predicates can match them. Generated-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLOATbinding folds comparisons against finite out-of-rangeDOUBLEliterals to constants and treats double infinities as out of range. This can misclassify NaN, infinite, and null values. Keep ordering comparisons against the appropriate finite float endpoint, and preserve infinities when converting double literals to float.Fixes #18700.
Test plan: compare FLOAT evaluation with equivalent DOUBLE evaluation for ordering, equality, and IN/NOT IN predicates, including finite limits, infinities, NaN, and null; verify literal conversion and binding shapes. All 9 new regression cases fail before the fix. The API module check reports 1351 tests, 1 skipped, and no failures/errors. Formatting, production/test Checkstyle, and module assembly pass.
AI Disclosure