Repository navigation
Spark 4.2: Test INSERT into a computed IDENTIFIER target - #18986
Open
shivadarshan-devadiga wants to merge 1 commit into
Open
shivadarshan-devadiga wants to merge 1 commit into
shivadarshan-devadiga wants to merge 1 commit into
Conversation
Author
|
@manuzhang @szehon-ho Can you please take a look whenever you get a moment. Thanks! |
Co-authored-by: Manu Zhang <owenzhang1990@gmail.com>
shivadarshan-devadiga
force-pushed
the
spark-test-insert-computed-identifier
branch
from
November 16, 2026 08:40
d83fa0d to
d0f7008
Compare
Author
|
Gentle ping @manuzhang @szehon-ho |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18950.
SPARK-58933 fixes expression resolution in the target of
INSERT INTO IDENTIFIER(...). This addstestInsertIntoComputedIdentifiertoTestSparkCatalogOperationsinspark/v4.2: it inserts intoIDENTIFIER(lower('<table>'))and checks the inserted row. The test is theinsertIntoComputedIdentifierregression from the Spark 4.2.1 verification draft #18294 by @manuzhang, kept as a permanent test.It is added to Spark 4.2 only. The bug is in Spark 4.2.0 and fixed in 4.2.1. On Spark 4.1.4, the version
spark/v4.1uses, the same test passes for all 4 catalogs.Testing:
TestSparkCatalogOperationspasses too.spark42set to 4.2.0, which doesn't have SPARK-58933, all 4 runs fail withUNSUPPORTED_INSERT.RDD_BASED: Can't insert into the target.spark/v4.1on Spark 4.1.4, it passes for all 4 catalogs.spotlessCheckpasses.