Repository navigation
Conversation
3 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16292 added plan-time checks in
SparkBatchbecause the vectorized reader could not decode shredded VARIANTtyped_value: a scan goes to the row reader when the table setswrite.parquet.shred-variants=true, the variant column usesnoneorcountsmetrics, or a file has variant lower bounds, whichSparkScanBuilderloads stats for. These checks guess the file layout and miss both ways: shredded files without the property and without variant bounds, such as arrays, failed (#18601), and unshredded files in such tables never vectorize. #18851 makes the reader handle shredded files per file, so this removes the checks and the stats loading. Those scans follow the same vectorization rules as unshredded variants, and disabling vectorization still selects the row reader.Part of #18669.
Test plan: Spark 4.2
TestSparkVariantReadasserts the scan is columnar only when vectorization is enabled. These fail without this change:readShreddedEnabledByTableProperty(property),testReadShreddedWithMetricsDisabled(noneandcounts, with the property also set),readMixedObjectShreddedAndUnshreddedFilesand the vectorized case oftestReadShreddedAfterPropertyToggled(variant bounds, batch scan),readShreddedIncrementalAppendScan(incremental append scan) andreadShreddedVariantAfterDelete(merge-on-read delete). The new tests compare vectorized and row-reader bytes.AI Disclosure