Skip to content

[ResourceManagerMapper ]The sql annotation form is optimized to XML - #3618

Merged
casionone merged 6 commits into
apache:dev-1.3.1from
binbinCheng:dev-1.3.1-ResourceManagerMapper-sql
Oct 18, 2022
Merged

casionone merged 6 commits into
apache:dev-1.3.1from
binbinCheng:dev-1.3.1-ResourceManagerMapper-sql

Conversation

@binbinCheng

Copy link
Copy Markdown
Contributor

[ResourceManagerMapper ]The sql annotation form is optimized to XML

Related issues: #3617

@binbinCheng binbinCheng changed the title The sql annotation form is optimized to XML [ResourceManagerMapper ]The sql annotation form is optimized to XML Oct 12, 2022
@codecov

codecov Bot commented Oct 12, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #3618 (8ea8d9e) into dev-1.3.1 (0fe2eff) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             dev-1.3.1    #3618   +/-   ##
============================================
  Coverage        14.29%   14.29%           
  Complexity        1523     1523           
============================================
  Files             1032     1032           
  Lines            38197    38197           
  Branches          5375     5375           
============================================
  Hits              5461     5461           
+ Misses           32005    32003    -2     
- Partials           731      733    +2     
Impacted Files Coverage Δ
...a/org/apache/linkis/scheduler/queue/Consumer.scala 85.71% <0.00%> (-14.29%) ⬇️
...r/engineplugin/python/executor/PythonSession.scala 58.91% <0.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…ceManagerMapper-sql

# Conflicts:
#	linkis-computation-governance/linkis-manager/linkis-manager-persistence/src/main/java/org/apache/linkis/manager/dao/ResourceManagerMapper.java
#	linkis-computation-governance/linkis-manager/linkis-manager-persistence/src/main/java/org/apache/linkis/manager/dao/impl/ResourceManagerMapper.xml
</select>

<insert id="registerResource" parameterType="org.apache.linkis.manager.common.entity.persistence.PersistenceResource">
INSERT INTO linkis_cg_manager_linkis_resources VALUES

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing @Options(useGeneratedKeys = true, keyProperty = "id", keyColumn = "id")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants