Repository navigation
[cdc] Fix pre-epoch values in temporal computed columns with micro and nanosecond precision - #11184
Open
chenjian2664 wants to merge 1 commit into
Conversation
…d nanosecond precision Temporal computed columns split epoch microseconds and nanoseconds with truncating division, so a negative value with a sub-millisecond part produced a negative nanos-of-millisecond and Timestamp rejected it. Use floor division and modulo so pre-1970 values convert correctly.
chenjian2664
marked this pull request as ready for review
November 16, 2026 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Temporal computed columns with epoch precision 6 or 9, such as
year(col, 6)ordate_format(col, yyyy-MM-dd, 9), throwIllegalArgumentExceptionfor a negative epoch value with a sub-millisecond part, for example-1500microseconds. This stops the CDC sync job on the first pre-1970 record. The epoch value was split into milliseconds and nanos-of-millisecond with truncating division, which gives a negative remainder thatTimestamprejects; it now uses floor division and modulo.Tests