Repository navigation
[core] Preserve append order during full compaction - #11189
Open
zhangyue19921010 wants to merge 1 commit into
Open
zhangyue19921010 wants to merge 1 commit into
zhangyue19921010 wants to merge 1 commit into
Conversation
Co-authored-by: TRAE CLI <traecli@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #11188.
Full compaction copies candidates from a priority queue whose iterator does not preserve sequence order. After an automatic compaction requeues a small result, a bucket that previously reads
[0, 1, 2, 3, 4]can be rewritten as[0, 1, 2, 4, 3]despitebucket-append-ordered = true.Sort full-compaction candidates by minimum sequence number before filtering and rewriting them.
Tests
Added a Java table regression that writes five real files, commits automatic compaction, performs full compaction, and reads both states through an initial streaming scan. It fails on unchanged upstream
f1ffd1369with[0, 1, 2, 4, 3]and passes with the change. No file metadata is fabricated.11 selected tests passed on JDK 11.0.18, covering full compaction, automatic candidate selection, ordered split/read behavior and repeated compaction cleanup. Maven
verifyran the selected suite twice; one existing disabled candidate-selection test was skipped in each run. Checkstyle, Spotless, Enforcer and RAT passed withoutfast-build.Prepared with TRAE CLI.