Repository navigation
Conversation
saves Keep a repository's submitted values visible while its save is pending, even when another repository's save refreshes the list. Reconcile completed saves with post-save fetch snapshots and accept server-confirmed values that differ from the submission. Add unit and browser regression coverage for concurrent saves, missing refetches, and temporary value regressions
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When two repository cards save concurrently, the first save can refresh the entire list before the second save finishes. The second card then briefly shows its old server value, replacing the submitted value until its own refresh completes.
This change keeps each card’s submitted values visible until the host confirms its save with a subsequent fetch. The host returns a versioned repository snapshot through the save callback, so React can distinguish save completion from an unrelated list refresh and ignore older responses.
The confirming server values are accepted even when they differ from the submission, preserving support for path normalization and repositories whose settings updates are no-ops.
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
Run the unit tests from
zeppelin-web-angular:These cover save/refetch ordering, pending values during unrelated refreshes, acceptance of different server values, and editing/Cancel behavior.
With the Zeppelin backend running on
localhost:8080, run the browser regression test from the same directory:The Playwright configuration starts the frontend automatically. The test mocks repository API responses to control the concurrent saves:
GETvalue, which deliberately differs from its submitted value.Questions: