Repository navigation
fix(CI): keep full module graph in karma bundle on webpack >= 5.112 - #1723
Open
sharmabikram wants to merge 4 commits into
Open
sharmabikram wants to merge 4 commits into
sharmabikram wants to merge 4 commits into
Conversation
josecorella
reviewed
Oct 29, 2026
Comment on lines
+49
to
+54
| // webpack >= 5.112 defers the re-exports of packages marked | ||
| // `sideEffects: false` and, in development mode, drops modules that | ||
| // our `export *` barrels need (e.g. @aws-crypto/cache-material), | ||
| // so the bundle builds but throws at runtime. Treating every module | ||
| // as side-effectful keeps the full module graph. karma-webpack | ||
| // ignores `optimization`, so this has to be a module rule. |
Contributor
There was a problem hiding this comment.
i don't quite understand what this is trying to say
Contributor
Author
There was a problem hiding this comment.
Fair — that was too jargon-heavy. Reworded it to say what actually happens: our packages declare "sideEffects": false, webpack 5.112+ dev builds use that to skip re-exported modules (dropping @aws-crypto/cache-material), and this rule makes webpack include everything. Also noted why it's a module rule rather than optimization.sideEffects (karma-webpack strips optimization).
josecorella
previously approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes the daily CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: