You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ModelTrainer bug with method to load hyperparameters from file for Amazon Nova Recipe #5770
Describe the bug Code is using method self._validate_and_load_hyperparameters_file instead of self._validate_and_fetch_hyperparameters_file`:
if is_nova:
if hyperparameters and isinstance(hyperparameters, str):
hyperparameters = cls._validate_and_load_hyperparameters_file(hyperparameters) # bug
model_trainer_args["hyperparameters"].update(hyperparameters)
elif hyperparameters and isinstance(hyperparameters, dict):
model_trainer_args["hyperparameters"].update(hyperparameters)
To reproduce
from sagemaker.train.model_trainer import ModelTrainer
from sagemaker.train.configs import Compute
model_trainer = ModelTrainer.from_recipe(
training_image="327873000638.dkr.ecr.us-east-1.amazonaws.com/hyperpod-recipes:verl-v1.0.0-smtj",
training_recipe="training/nova/nova_1_0/nova_lite/CPT/nova_lite_1_0_p5x16_gpu_pretrain",
compute=Compute(instance_type="ml.m5.xlarge"),
hyperparameters="test",
)
changed the title [-]Fix `ModelTrainer` bug with method to load hyperparameters from file for Amazon Nova Recipe[/-][+]`ModelTrainer` bug with method to load hyperparameters from file for Amazon Nova Recipe[/+]on Apr 17, 2026
Activity
[-]Fix `ModelTrainer` bug with method to load hyperparameters from file for Amazon Nova Recipe[/-][+]`ModelTrainer` bug with method to load hyperparameters from file for Amazon Nova Recipe[/+]test(train): cover from_recipe Nova hyperparameters file path
Fix incorrect `model_trainer` method call to load hyperparameters fro…