Skip to content

Change: Type checking with Pydantic - #4265

Closed
martinRenou wants to merge 7 commits into
aws:masterfrom
martinRenou:pydantic
Closed

Change: Type checking with Pydantic#4265
martinRenou wants to merge 7 commits into
aws:masterfrom
martinRenou:pydantic

Conversation

@martinRenou

@martinRenou martinRenou commented Nov 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Fix #3809, allowing to catch these issues early.

Fix #4295 by removing the fastapi dependency

Description of changes:

Adds typing check to the Spark and SKLearn frameworks APIs, fixing some missing types.

Testing done:

This requires changing the tests so that the pydantic type validation works with ours mocks.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mufaddal-rohawala

mufaddal-rohawala commented Nov 21, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 33f726d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 21, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 33f726d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 21, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 33f726d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 21, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 33f726d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 21, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 33f726d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 23, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 979c384
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 23, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 979c384
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 23, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 979c384
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 23, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 979c384
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 23, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 979c384
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 24, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b282a94
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 24, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b282a94
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 24, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b282a94
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 24, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b282a94
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 24, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b282a94
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 27, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e68a8c1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 27, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e68a8c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 27, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e68a8c1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 27, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e68a8c1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 27, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e68a8c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@martinRenou
martinRenou force-pushed the pydantic branch 2 times, most recently from 1645e69 to 70c96bc Compare November 28, 2023 08:51
@mufaddal-rohawala

mufaddal-rohawala commented Nov 28, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 70c96bc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 28, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 70c96bc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 28, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5536838
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Nov 28, 2023

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bf5bcba
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 0716164
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: bcb78de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: bcb78de
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: bcb78de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: bcb78de
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bcb78de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@wentao-lu

wentao-lu commented Jan 2, 2024

Copy link
Copy Markdown

Is there anything we could help to get this merged?

mufaddal-rohawala
mufaddal-rohawala reviewed Jan 2, 2024
View reviewed changes

@mufaddal-rohawala mufaddal-rohawala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests, unit-tests, pr

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: bcb78de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: bcb78de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: bcb78de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 2, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bcb78de
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 5fd09e4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 5fd09e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 5fd09e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 5fd09e4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Jan 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5fd09e4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure

knikure commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

@martinRenou Can you please resolve conflicts?

@martinRenou
martinRenou dismissed stale reviews from akrishna1995 and mohanasudhan via 5fd09e4 June 14, 2024 14:20
@jam-jee jam-jee mentioned this pull request Sep 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala left review comments
@jgoyani1 jgoyani1 Awaiting requested review from jgoyani1 jgoyani1 was automatically assigned from aws/sagemaker-ml-frameworks
+2 more reviewers
@mohanasudhan mohanasudhan mohanasudhan left review comments
@akrishna1995 akrishna1995 akrishna1995 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@knikure knikure

Labels

None yet

Projects

None yet

Milestone

No milestone

9 participants

@martinRenou @mufaddal-rohawala @codecov-commenter @mohanasudhan @knikure @PhMueller @wentao-lu @akrishna1995 @mohamedzeidan2021