Skip to content

feat(evm): expose block finalization timings - #45

Open
fahimahmedx wants to merge 1 commit into
releases/v2.8.1from
fahim/payload-finalization-timings
Open

fahimahmedx wants to merge 1 commit into
releases/v2.8.1from
fahim/payload-finalization-timings

Conversation

@fahimahmedx

Copy link
Copy Markdown

Return the sparse trie worker’s elapsed and idle wall time with its result. With EVM metrics enabled, return the time spent merging transitions, hashing post-state, and calling the synchronous root provider. A precomputed root has no synchronous sample. This lets Base attribute timings to composed blocks rather than mixing in validation and replay.

Validated with 258 unit tests across the three affected crates, Clippy with tests and the production serde feature, and a no-default-features check for reth-evm.

type=routine
risk=low
impact=sev5

@fahimahmedx

Copy link
Copy Markdown
Author

CI triage: cargo-deny flags advisories in the existing releases/v2.8.1 dependency set. This PR and its base have byte-identical Cargo.lock, manifests, deny policy, and workflows. I have not suppressed any advisories; the release dependency set needs remediation independently of these timing changes. The Cyclops publish job also reports that EVENTS_ARGS contains no curl argument. That needs repository workflow configuration before retrying.

@fahimahmedx

Copy link
Copy Markdown
Author

Both new Clippy failures report the same two doc_markdown errors at crates/storage/storage-api/src/state.rs:197,199 (missing backticks around StateProvider). I verified that file is identical to releases/v2.8.1. Neither job reached a timing-code diagnostic. Release-branch lint cleanup is separate from the previously noted cargo-deny and Cyclops blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant