Skip to content

fix(pypi): reject the not operator in the env markers - #4551

Open
aignas wants to merge 1 commit into
bazel-contrib:fix.aignas.version-bzl-08-parse-oncefrom
aignas:fix.aignas.version-bzl-09-no-not
Open

aignas wants to merge 1 commit into
bazel-contrib:fix.aignas.version-bzl-08-parse-oncefrom
aignas:fix.aignas.version-bzl-09-no-not

Conversation

@aignas

@aignas aignas commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

The dependency specifiers spec does not have a unary not, only the
not in operator, and packaging rejects the markers that use it. We
used to accept it as an extension, which means that an invalid marker
was evaluated instead of being reported.

Removing it also means that the evaluation no longer needs to track
the pending negations for each parenthesis.

Stacked on #4550.

The dependency specifiers spec does not have a unary `not`, only the
`not in` operator, and `packaging` rejects the markers that use it. We
used to accept it as an extension, which means that an invalid marker
was evaluated instead of being reported.

Removing it also means that the evaluation no longer needs to track
the pending negations for each parenthesis.
@aignas

aignas commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

This PR was prepared by an AI agent (Claude Code) working for the author. The author reads the review comments and decides how they are handled; any reply posted by the agent will say so.

This is an agent-generated comment unreviewed by the user.

@aignas
aignas marked this pull request as ready for review November 21, 2026 02:44
@aignas
aignas requested a review from rickeylev as a code owner November 21, 2026 02:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant