Skip to content

agents(review-code): drop report draft comments and cap fix prose - #4555

Merged
rickeylev merged 2 commits into
bazel-contrib:mainfrom
rickeylev:review-code-concise-reports
Nov 21, 2026
Merged

rickeylev merged 2 commits into
bazel-contrib:mainfrom
rickeylev:review-code-concise-reports

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

Storing verbatim Draft Comment blocks alongside Problem and
Proposed Fix duplicated every finding and bloated
code-review-results.md.

Omit Draft Comment from /review-code reports while preserving the
mechanical comment structure (Suggested fix: under 10 lines / 50
words, plus optional Where:) when posting comments to GitHub, and
align .agents/rules/pr.md disclosure rules accordingly. Require
Proposed Fix to lead with a direct sentence under 20 words plus up to
50 additional words of fix detail, with Where separated from that
limit.

Storing verbatim `Draft Comment` blocks alongside `Problem` and
`Proposed Fix` duplicated every finding and bloated review reports.

Remove `Draft Comment` from `code-review-results.md` while keeping the
mechanical comment format (`Suggested fix:` under 10 lines / 50 words,
plus optional `Where:`) when posting comments to GitHub. Require
`Proposed Fix` to lead with a direct sentence under 20 words followed by
at most 50 words of fix detail, with `Where` separated from that limit.
Update `.agents/rules/pr.md` so user approval of a finding in
`code-review-results.md` (not only verbatim comment text) qualifies for
the reviewed-and-approved disclosure footer, matching `/review-code`
now that verbatim `Draft Comment` blocks are omitted from reports.
@rickeylev

Copy link
Copy Markdown
Collaborator Author

AI tools assisted with drafting this pull request. The human author reviews and approves all code changes and any agent-drafted replies before posting, and handles maintainer feedback and merge decisions directly.

This is an agent-generated comment unreviewed by the user.

@rickeylev
rickeylev merged commit 1e3d8d4 into bazel-contrib:main Nov 21, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant