Repository navigation
test(windows): skip the symlink case of the cached venv test without symlinks - #4571
Open
AustinSchuh wants to merge 1 commit into
Open
AustinSchuh wants to merge 1 commit into
AustinSchuh wants to merge 1 commit into
Conversation
…symlinks `test_replaces_dangling_package_link_before_creating_child_link` needs to create symlinks, so it fails on Windows without the privilege to create them. Skip it there. The junction case still runs.
Contributor
Author
|
OK, this and 4572 make everything work on Windows for me. Treat these as suggestions/bug reports if you'd like to do them a different way. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_replaces_dangling_package_link_before_creating_child_linkneedsto create symlinks, so it fails on Windows without the privilege to
create them, which is the case #4509 is for. Skip it there. The
junction case still runs.
Tested on Windows 11 26H2 with Developer Mode off: the symlink case is
skipped and the other two cases pass. On
main, the symlink casefails. The tests also pass on Linux.