Skip to content

Strict mode? #37

Closed
Closed

Description

@jprichardson

Node v9.9.0 introduced some changes into the assert package. Most notably the introduction of strict mode.

Would you accept a PR introducing this new functionality and bringing this module up to date?

Activity

  1. jprichardson commented on Sep 20, 2018

    @jprichardson
    MemberAuthor

    If it simplifies the maintenance burden on your end @defunctzombie - how would you feel about moving this repo to the browserify org?

  2. defunctzombie commented on Sep 20, 2018

    @defunctzombie
    Contributor

    @jprichardson I'd be open to that (clearly I have let this module go by the wayside) - what would that require logistically?

  3. calvinmetcalf commented on Sep 20, 2018

    @calvinmetcalf
    Collaborator

    I think you'd have to grant ownership of the project to somebody who is an admin in the browserify org, which would include both me and @jprichardson

  4. defunctzombie commented on Sep 20, 2018

    @defunctzombie
    Contributor

    @calvinmetcalf you are already listed as a collaborator on the repo - is there some other action that "grants ownership" ?

  5. calvinmetcalf commented on Sep 20, 2018

    @calvinmetcalf
    Collaborator

    i just invited you into the browserify org

  6. defunctzombie commented on Sep 22, 2018

    @defunctzombie
    Contributor

    @calvinmetcalf Should I see a notification somewhere for that? I received no email about it.

  7. jprichardson commented on Sep 22, 2018

    @jprichardson
    MemberAuthor

    I tried to invite you again @defunctzombie. Looks like you were invited by Substack awhile ago. See if you can visit this link: https://github.com/organizations/browserify/settings/profile and if there is something about accepting the invite.

  8. defunctzombie commented on Sep 23, 2018

    @defunctzombie
    Contributor

    @jprichardson I get a 404 when I visit that link.

  9. jprichardson commented on Sep 23, 2018

    @jprichardson
    MemberAuthor

    @defunctzombie I canceled the invite, and then invited you again. Any email now...?

  10. defunctzombie commented on Sep 23, 2018

    @defunctzombie
    Contributor

    @jprichardson @calvinmetcalf repository transferred. Feel free to remove me from the browserify organization.

  11. kuraga commented on Sep 24, 2018

    @kuraga

    Wow! I've come here at the right moment... 😄 👍

  12. kuraga commented on Sep 24, 2018

    @kuraga

    @jprichardson It would be very nice if we'll get a NodeJS-compatibility. I.e. commonjs-assert x.y is compatible with NodeJS x.y!

  13. fabiosantoscode commented on Nov 2, 2018

    @fabiosantoscode

    Any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions