This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 23, 2023. It is now read-only.
FR: Include Google Cloud Pub/Sub in distributed tracing #1013
Description
Google Cloud Engineer filing on behalf of a Google Cloud customer.
Customer expects distributed tracing flows to span Google Cloud Pub/Sub service.
As favored messaging service for GCP customers, Pub/Sub is a foundational component of many customer solutions and if the service does not integrate tracing spans, this makes OpenCensus (tracing) less useful.
Customers prefers Java although this FR transcends specific runtimes and should be provided for all
Requst Java, Golang initially.
Reacted by Justin White, Jason Kuhrt, Justin Thomas, Stian Lågstad, Ben, marcel corso gonzalez, Marc hurabielle and Drew Michel
Activity
sebright2 commentedon Feb 22, 2018
/cc @bogdandrutu @HailongWen
HailongWen commentedon Feb 22, 2018
Ack. I am on vacation now and might not be able to respond to this timely.
Meanwhile, @DazWilkin please refer to the integration we've done in googleapis/google-cloud-java#2846 which demonstrated some basic ideas of how OpenCensus integrate with GCS.
DazWilkin commentedon Feb 22, 2018
@HailongWen Thank you! I'm leaving on vacation tomorrow but I'll pass this along to my customer and will try to find some time to investigate applying this to Pub/Sub when I return.
bogdandrutu commentedon Feb 23, 2018
@DazWilkin can you tell me more details about this? Does this request imply pub/sub passing internally the cloud trace context and also maybe participate in the trace or just the client library instrumented?
DazWilkin commentedon Feb 23, 2018
The customer (and others) want to be able to have traces that span services that span Pub/Sub. So, the former. E.g. App Engine receiving a client request, publishing a message to Pub/Sub that perhaps triggers a GKE service and dumps something onto Spanner.
bogdandrutu commentedon Feb 23, 2018
@DazWilkin Awesome. This implies some internal discussions as well about instrumenting the Pub/Sub service internally correct?
DazWilkin commentedon Feb 23, 2018
Filing this FR is a catalyst for these discussions to begin (if not already) or to help me get folded into them so that I may pursue for this (and all) customers.
songy23 commentedon Jan 29, 2019
@dinooliva Should we mark this as complete?
songy23 commentedon Apr 18, 2019
IIUC Cloud Pub-Sub integration in Java is done. Tutorial can be found at https://opencensus.io/integrations/google_cloud/google_cloud_pubsub/java/.
deanberris commentedon May 24, 2019
Is there a chance that these convenience functions/types would be implemented in Go/Python?
songy23 commentedon May 24, 2019
@deanberris Feel free to open a feature request under https://github.com/census-instrumentation/opencensus-specs.