Repository navigation
fix: count Vue-completed exercises in course reporting top students - #9435
Open
mrpythonist wants to merge 1 commit into
Open
mrpythonist wants to merge 1 commit into
mrpythonist wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9423
What?
In course reports, "Top students" showed 50% progress for a student who completed the whole learning path.
The score is
floor((learningPathProgress + exerciseAverage) / 2)inCourseReportingQueryService::getOverview(). The exercise average came fromtrack_e_exerciseswithstatus = ''only, which is the legacy finished status.The current Vue exercise runtime finishes attempts with
status = 'completed'(ExerciseRuntimeFinishProcessor), so those attempts were ignored and the average stayed 0:(100 + 0) / 2 = 50.This changes the filter to
status IN ('', 'completed'), the same pair the codebase already uses inExerciseOverviewProviderandExerciseRuntimeResultProvider(STATUS_LEGACY_COMPLETED = '').Why?
A completed exercise should count toward the average whichever runtime finished it. In-progress attempts (
status = 'incomplete') are still excluded.How?
One line in
src/CoreBundle/Service/CourseReporting/CourseReportingQueryService.php(loadLearnerMetrics()).Test
php -lon the changed file: no syntax errors.''attempt still counts and anincompleteattempt still does not.