Repository navigation
Conversation
…on - refs chamilo#2641 PDF::fixImagesPaths() still assumed the 1.11 course layout and read $courseInfo['path'], which Chamilo 2 course info no longer has. With the dev error handler this turned every Test2Pdf export of a test or question that has a description into a fatal error. Only use the legacy app/courses/<path>/document/ rewriting when the course info actually has a path, and inline images served by Chamilo 2 resource URLs (/r/{tool}/{type}/{uuid}/view) as data URIs after a ResourceNodeVoter VIEW check, since mPDF cannot fetch them without the user's session.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDF::fixImagesPaths() still assumed the 1.11 course layout and read $courseInfo['path'], which Chamilo 2 course info no longer has. With the dev error handler this turned every Test2Pdf export of a test or question that has a description into a fatal error.
Only use the legacy app/courses//document/ rewriting when the course info actually has a path, and inline images served by Chamilo 2 resource URLs (/r/{tool}/{type}/{uuid}/view) as data URIs after a ResourceNodeVoter VIEW check, since mPDF cannot fetch them without the user's session.