Repository navigation
Conversation
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getElementsAtEventForMode(..., true)asks interaction modes to use final animation positions, but candidate pruning still binary-searches current element pixels. A point moving away from its current neighbors can therefore be excluded before its target position is hit-tested. The laterinRange(..., true)call cannot recover a pruned point.Change
Pass the final-position flag through candidate evaluation. For sorted index-axis data, binary-search element target coordinates via
getPropsinstead of current coordinates. The existing current-position path is unchanged. The target search remains logarithmic and does not allocate a full target-coordinate array.Twenty regression scenarios use real
Chart.Animationinstances with ordered targets across x/y index axes, reversed scales, and point/nearest/index/dataset/axis modes. Eight fail against unchanged base71d4421; all twenty pass with the change. The tests also check that current-position queries do not return a point only intersecting at its target.Validation
Tested in a separate exact-base tree without #12358's reversed-intersection fix. This addresses final-position lookup, not that independent range-order bug. Firefox was not run; its executable is unavailable in this environment. Package integration suites were not run.