Making ns-qualified keywords not have font-lock-type-face #468

Activity

1. vemv commented on Jan 20, 2018

   

   vemv

   on Jan 20, 2018

   MemberAuthor

   More actions

   In case it helps, this is the culprit:

         ;; foo/ Foo/ @Foo/ /FooBar
         (,(concat "\\(?:\\<:?\\|\\.\\)@?\\(" clojure--sym-regexp "\\)\\(/\\)")
          (1 font-lock-type-face) (2 'default))
   
2. bbatsov commented on Mar 28, 2018

   

   bbatsov

   on Mar 28, 2018

   Member

   More actions

   @Bost I think your ns font-locking changes addressed this, right?
3. Bost commented on Mar 28, 2018

   

   Bost

   on Mar 28, 2018

   Contributor

   More actions

   @Bost I think your ns font-locking changes addressed this, right?

   Yes it does. (@vemv Bozo references to the 14d4221.)
   A bit of an explanation - the ::kws.grid/column-settings is not a valid keyword. I assume we want to take a look at :kws.grid/column-settings, then:

   user> ::kws.grid/column-settings
   RuntimeException Invalid token: ::kws.grid/column-settings  clojure.lang.Util.runtimeException (Util.java:221)
   user> :kws.grid/column-settings
   :kws.grid/column-settings
   user> (namespace :kws.grid/column-settings) ;; namespace font-locked as font-lock-type-face
   kws.grid
   user> (name :kws.grid/column-settings) ;; keyword names font-locked as clojure-keyword-face
   column-settings
   user>

   And here is how is looks like:
   

   So to answer:

   (font-lock-type-face clojure-keyword-face) I'm not sure if this is a feature. To me it looks buggy. grid does not have a special meaning.

   Yea you were looking at a buggy feature implementation, now hopefully fixed. Please get the 14d4221 and have a look again.
4. vemv commented on Mar 28, 2018

   

   vemv

   on Mar 28, 2018

   MemberAuthor

   More actions

   ::kws.grid/column-settings is not a valid keyword

   For the record: it is - if you :require x as kws.grid, then ::kws.grid/column-settings will become a valid keyword in the current ns/context.

   Will checkout CIDER @ latest asap.

   Thanks!
5. Bost commented on Mar 28, 2018

   

   Bost

   on Mar 28, 2018

   Contributor

   More actions

   What??? Egh...

   user> (require '[clojure.core :as kws.grid])
   nil
   user> ::kws.grid/fn
   :clojure.core/fn
   user> ::kws.grid/ufo
   :clojure.core/ufo
   user> (namespace ::kws.grid/ufo)   ;; I wonder how many folks get confused over this?
   clojure.core
   user> (name ::kws.grid/ufo)
   ufo
   user> (name :kws.grid/ufo)
   ufo
   user> (namespace :kws.grid/ufo)
   kws.grid
   user> 

   egh... really. I think it would be a good idea to indicate it with some different font-face. @bbatsov?
6. vemv commented on Mar 28, 2018

   

   vemv

   on Mar 28, 2018

   MemberAuthor

   More actions

   (namespace ::kws.grid/ufo) might be bit of an unfair example ;p

   One normally aliases using close terms (e.g clojure -> clj)

   Thus, (namespace ::clj.cr/fn) returning :clojure.core/fn seems more defensible!

   So a different font-fact may be overkill.
7. MalloZup commented on Aug 5, 2019

   

   MalloZup

   on Aug 5, 2019

   More actions

   autogenerated with https://github.com/MalloZup/doghub: issue inactive since 450 days. Please update the issue or close it