Skip to content

fix: Add explicit inline padding to drawer buttons - #2009

Merged
jperals merged 2 commits into
mainfrom
fix/button-padding-ipad
Feb 27, 2024
Merged

jperals merged 2 commits into
mainfrom
fix/button-padding-ipad

Conversation

@jperals

@jperals jperals commented Feb 27, 2024 •

Copy link
Copy Markdown
Member

Description

Fixes #2008 by setting an explicit inline padding of 0 to drawer buttons. Without it, different devices would add a different padding. Since the text is centered, in most cases this did not matter except in iPad where this padding is big enough (14px) for the text not to fit and be brought to the right.

How has this been tested?

Tested the app-layout/default page in an iPad simulator; compared this version with the fix against another version without the fix.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Feb 27, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.83%. Comparing base (0a03e17) to head (f17b88d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files         669      669           
  Lines       18110    18110           
  Branches     5999     5999           
=======================================
  Hits        17175    17175           
  Misses        870      870           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannes-weber johannes-weber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Verified the changes on am iPad.

This branch was successfully deployed

2 active deployments
dev-pages — f17b88db Deployed Feb 27, 2024 by jperals
visual-regression-report — f17b88db Deployed Feb 27, 2024 by jperals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Fix side navigation button positioning on iPad

3 participants