Repository navigation
fix: Add explicit inline padding to drawer buttons - #2009
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2009 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 669 669
Lines 18110 18110
Branches 5999 5999
=======================================
Hits 17175 17175
Misses 870 870
Partials 65 65 ☔ View full report in Codecov by Sentry. |
connorlanigan
approved these changes
Feb 27, 2024
connorlanigan
approved these changes
Feb 27, 2024
johannes-weber
approved these changes
Feb 27, 2024
johannes-weber
left a comment
Member
There was a problem hiding this comment.
Approved! Verified the changes on am iPad.
Open
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2008 by setting an explicit inline padding of 0 to drawer buttons. Without it, different devices would add a different padding. Since the text is centered, in most cases this did not matter except in iPad where this padding is big enough (14px) for the text not to fit and be brought to the right.
How has this been tested?
Tested the
app-layout/defaultpage in an iPad simulator; compared this version with the fix against another version without the fix.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.