Skip to content

Consider replacing array of options with dedicated methods #154

New issue
New issue
Closed
#172
Closed
Consider replacing array of options with dedicated methods#154
#172
Labels
BC breakhelp wantednew feature

Description

@clue
clue
opened on Mar 1, 2020

For instance:

// old
$browser->withOptions(array('timeout' => 10))->post(…);

// new
$browser->withTimeout(10)->post(…);

This can be added in a 2.x release by deprecating the withOptions() method and still using this method under the hood. In a 3.0 release this method could be removed altogether.

Any input is welcome 👍

Activity

  1. clue
    added
    new feature
    BC break
    on Mar 1, 2020

  2. WyriHaximus commented on Mar 12, 2020

    @WyriHaximus
    WyriHaximus
    on Mar 12, 2020
    Contributor

    I'll pick this up a create a PR

  3. WyriHaximus commented on Mar 12, 2020

    @WyriHaximus
    WyriHaximus
    on Mar 12, 2020
    Contributor

    PR is up at #155

  4. clue
    added
    help wanted
    on Mar 13, 2020
  5. clue
    closed this as completedin #172on Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BC breakhelp wantednew feature

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions