Repository navigation
fix(compose): return when logs has no matching containers - #5299
Merged
AkihiroSuda merged 1 commit intoNov 15, 2026
Merged
Conversation
An empty container list leaves compose logs waiting for an EOF event that cannot arrive. Return success immediately, matching Docker, and cover both log modes with and without an explicit service. Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compose logsgets stuck when no containers match, e.g. before the firstcompose upor aftercompose down. Return early for an empty list, like Docker does.Repro with a running containerd, no image pull needed:
Current main hangs. With this fix it exits 0; same for
logs -f.Verified: four CLI cases on containerd and Docker, existing-container logs/follow/tail,
make test, affected-package lint. Full lint reports an existing gci error incontainer_list.go:112.