Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

can't get it to run the rvm ruby #5

Open

Description

@ericcj

despite having the rvm stuff in my bash_profile and bashrc i can't get this hook to use the rvm ruby when called with the shebang #!/usr/bin/env ruby. seems to work fine at the terminal, does git abandon all environment variables before running hooks?

beezo:~ ej$ /usr/bin/env ruby -v
ruby 1.9.3p374 (2013-01-15 revision 38858) [x86_64-darwin12.2.1]

beezo:~ ej$ git --version
git version 1.7.12.4 (Apple Git-37)
hub version 1.10.4

Activity

  1. cypher commented on Feb 15, 2013

    @cypher
    Owner

    Looks like it prepends PATH with /usr/bin (/usr/libexec/git-core:/usr/bin to be exact), thus the system Ruby is the first one it finds.

    I can think of two solutions right now: Either use the complete path to your version of Ruby as the shebang (e.g. /usr/local/rvm/bin/ruby-1.9.2-p290@projectX, see Using RVM with Cron for more details), or use a wrapper shell script that sources your RVM environment before execing the Ruby script.

  2. ericcj commented on Feb 15, 2013

    @ericcj
    ContributorAuthor

    using the path to the rvm ruby as the shebang isn't enough since below we do "which ruby". you can't actually use the wrapper scripts as shebangs either, they require being passed the ruby script as an argument. we also use "erb" without any path setup.

    i can get everything to work by manually replacing that line with:

    /Users/ej/.rvm/wrappers/default/erb -xT - views/admin/users/index.erb | /Users/ej/.rvm/wrappers/default/ruby -wc

    but it'd be nice to generalize. i guess we could do some hackery around looking if there's a ${HOME}/.rvm/wrappers/default like we do with rbx. there's a confusing git issue about whether this is even supposed to be the case: magit/magit#498 (comment)

  3. cypher commented on Apr 9, 2013

    @cypher
    Owner

    I think pretty much the only solution would be to restore the original $PATH by removing the first two entries. That way, rvm/rbenv should be used to get whatever Ruby you set.

    However, a possible downside is that this may have unintended side effects, like some git porcelain suddenly not working any more. And it's brittle as hell, since Git may change this behavior in future.

    I've just pushed 8c302a1, could you test with that commit and see if it works then? If it does, then maybe we can come up with a sane way to restore the original $PATH without possibly breaking everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions