Repository navigation
ci: Pin ubuntu to ubuntu-24.04 - #1447
Merged
Merged
Conversation
mofojed
commented
Nov 2, 2026
Member
- The ubuntu-latest tag recently moved to ubuntu 26.04: https://github.blog/changelog/2026-09-17-ubuntu-26-generally-available-and-latest-migration/#ubuntu-latest-is-migrating-to-ubuntu-26-04
- This was breaking our tests, e.g. https://github.com/deephaven/deephaven-plugins/actions/runs/40935678020/job/123665460047?pr=1445
- We pin to 24.04 everywhere else, just need to pin here as well
- The ubuntu-latest tag recently moved to ubuntu 26.04: https://github.blog/changelog/2026-09-17-ubuntu-26-generally-available-and-latest-migration/#ubuntu-latest-is-migrating-to-ubuntu-26-04 - We pin to 24.04 everywhere else, just need to pin here as well
mofojed
requested review from
jnumainville
and
a balanced review from Copilot
November 2, 2026 18:26
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change pinning the pre-commit runner to Ubuntu 24.04.
No open issues 🎉
What changed in this PR
Pins the pre-commit workflow to Ubuntu 24.04 to avoid runner-image changes associated with ubuntu-latest and address the reported test failures.
Changes:
- Replaces
ubuntu-latestwithubuntu-24.04; workflow steps remain unchanged.
| File | Description |
|---|---|
.github/workflows/pre-commit.yml |
Pins the pre-commit job runner to Ubuntu 24.04. |
Review effort: Balanced
jnumainville
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.