Skip to content

refactor(writer): narrow the node-stats API and cover child stats with unit tests (#583) - #675

Merged
dfa1 merged 1 commit into
mainfrom
test/583-child-stats-units
Nov 6, 2026
Merged

dfa1 merged 1 commit into
mainfrom
test/583-child-stats-units

Conversation

@dfa1

@dfa1 dfa1 commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Follow-up to the #674 review.

  • RootNodeStats is now package-private CachedNodeStats; VortexWriter uses one public EncodeResult#withRootStats.
  • Unit tests: dict children stats, nullable int/float validity bitmaps, patch values, keep-own-stats rule.
  • Interop test: nullable f64 column compared against vortex-jni.
  • Docs: three shapes, bit-packed patch values.

Not done: the second min/max pass in nodeStats (needs ArrayAndStats threaded through the cascade); nullable decimal interop.

🤖 Generated with Claude Code

https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV

… with unit tests (#583)

Review of #674: RootNodeStats is now the package-private CachedNodeStats, reached from
VortexWriter through one public EncodeResult#withRootStats. Unit tests cover the cached stats on
dict children, the validity bitmaps of a nullable integer and float, patch values and the
fill-only-when-empty rule; the interop test gains a nullable f64 column. Docs: three shapes, and
bit-packed patch values.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV
@dfa1
dfa1 merged commit e2729ed into main Nov 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant