Repository navigation
refactor(writer): narrow the node-stats API and cover child stats with unit tests (#583) - #675
Merged
Merged
Conversation
… with unit tests (#583) Review of #674: RootNodeStats is now the package-private CachedNodeStats, reached from VortexWriter through one public EncodeResult#withRootStats. Unit tests cover the cached stats on dict children, the validity bitmaps of a nullable integer and float, patch values and the fill-only-when-empty rule; the interop test gains a nullable f64 column. Docs: three shapes, and bit-packed patch values. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #674 review.
RootNodeStatsis now package-privateCachedNodeStats;VortexWriteruses one publicEncodeResult#withRootStats.Not done: the second min/max pass in
nodeStats(needsArrayAndStatsthreaded through the cascade); nullable decimal interop.🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV