Repository navigation
FR: Support dark mode for zoom-image plugin #2508
Description
Feature request
Problem or desire
Support dark mode for zoom-image plugin
Proposal
Support dark mode for zoom-image plugin
Implementation
Support dark mode for zoom-image plugin, instead of fixed white background
Reacted by Paul Hibbitts 🍁
Activity
BanerjeeAgniva commentedon Dec 20, 2024
@sy-records Hey I am new to open-source and coding, can you tell me what files I need to look into for this issue, thanks!
sy-records commentedon Dec 23, 2024
Hi, @BanerjeeAgniva
You can see https://github.com/docsifyjs/docsify/blob/develop/src/plugins/zoom-image.js
In
Dark Mode, a few style changes will do the trick.ZEviod commentedon Dec 23, 2024
Hello @sy-records, I’d like to work on adding this feature.
If yes, could you please clarify a few details to ensure alignment?
->Should the dark mode support be automatic (based on system preferences) or configurable via plugin options?
->Are there any existing guidelines, color schemes, or design patterns for dark mode in this project?
->Would you prefer dark mode styling to be implemented using CSS variables, a separate stylesheet, or another approach?
sy-records commentedon Dec 24, 2024
Automated, judgment by media query.
prefers-color-scheme: darkWe support dark mode in the new version, see https://github.com/docsifyjs/docsify/deployments/Preview , https://docsify-preview-hshwchgkk-docsifyjs.vercel.app/preview/#/themes?id=themes
I think adding some styling to zoom-image.js will do the trick!
trusktr commentedon Dec 25, 2024
@jhildenbiddle any preferences here that may be best aligned with Docsify and docsify-themeable?