nocontainer param no longer hides the container #923

Activity

1. runspired commented on Apr 15, 2022

   

   runspired

   on Apr 15, 2022

   Author

   More actions

   just coming back to this to see if anyone has looked into why? it's been broken almost 2 years.
2. runspired

   changed the title [-]hideContainer no longer hides the container[/-] [+]nocontainer param no longer hides the container[/+] on Apr 15, 2022
3. runspired commented on Apr 15, 2022

   

   runspired

   on Apr 15, 2022

   Author

   More actions

   The answer is that these lines:

   ember-qunit/addon-test-support/index.js

   Lines 86 to 89 in 4720360

   	let testContainer = document.getElementById('ember-testing-container');
   	if (!testContainer) {
   	return;
   	}

   run before the DOM is fully constructed.

   in my test's index.html I needed to move

       <div id="qunit"></div>
       <div id="qunit-fixture">
         <div id="ember-testing-container">
           <div id="ember-testing"></div>
         </div>
       </div>

   above

       <script src="/testem.js" integrity=""></script>
       <script src="{{rootURL}}assets/vendor.js"></script>
       <script src="{{rootURL}}assets/test-support.js"></script>
   
       <script src="{{rootURL}}assets/dummy.js"></script>
       <script src="{{rootURL}}assets/tests.js"></script>

   This is a funny "gotya" because everything about the tests continues to work as normal except this one feature. I suspect that feature should be made to grab the html element lazily.