[ef4]

This supersedes #21728 because the bug was fixed upstream.

[github-actions]

📊 Size report

Tarball size — 1.3 MB → 1.3 MB

dist/dev   -0.22%↓

File	Before (Size / Brotli)	After (Size / Brotli)
./packages/shared-chunks/compiler-{hash}.js	348.6 kB / 67 kB	-1.38%↓343.8 kB / -0.07%↓66.9 kB
./packages/shared-chunks/index-{hash}.js	62.6 kB / 12.5 kB	-89.4%↓6.6 kB / -88.7%↓1.4 kB
Total (Includes all files)	2.2 MB / 520.3 kB	-0.22%↓2.2 MB / -0.01%↓520.2 kB

---

dist/prod   -0.24%↓

File	Before (Size / Brotli)	After (Size / Brotli)
./packages/shared-chunks/api-{hash}.js	26.5 kB / 6 kB	-76.3%↓6.3 kB / -73.5%↓1.6 kB
./packages/shared-chunks/compiler-{hash}.js	361.9 kB / 69.4 kB	-1.33%↓357.1 kB / -0.15%↓69.3 kB
Total (Includes all files)	2 MB / 477 kB	-0.24%↓2 MB / -0.02%↓476.9 kB

---

smoke-tests/v2-app-template/dist   No changes

File	Before (Size / Brotli)	After (Size / Brotli)
Total (Includes all files)	359.3 kB / 97.1 kB	359.3 kB / 97.1 kB

---

smoke-tests/v2-app-hello-world-template/dist   No changes

File	Before (Size / Brotli)	After (Size / Brotli)
Total (Includes all files)	128.9 kB / 35.3 kB	128.9 kB / 35.3 kB

_{🤖 This report was automatically generated by wyvox/pkg-size}

[ef4]

The prettier failure is because we actually emit a more correct error message now in one test case. We can update to fix it, but will need to publish @glimmer/syntax first.

[NullVoxPopuli]

re: publishing @glimmer/syntax, here is an info dump of context:

• Detect changes per package from git history release-plan/release-plan#285
• Try @nullvoxpopuli/release-plan with per-package change detection #21729 (comment)

[ef4]

How do we feel about marking the prettier smoke tests as an allowed failure to break the cycle here?

1. Allow failure here.
2. Land this PR, ember main stays green.
3. We sort out the publishing and publish @glimmer/syntax from main.
4. We PR prettier to expect the new @glimmer/syntax (which just changes an error message wording).
5. We disallow failure again.

[NullVoxPopuli]

Allow failure here

did GH finally add this status?

afaict, the failure is non-blocking / non-required as is

[ef4]

well, what I really mean is, I'd prefer not to confuse every PR with a red test while we wait for pettier to merge a PR. So I guess I mean "skip" instead of "allow failure".