Repository navigation
Count only source files in release-plan change detection - #21733
Closed
NullVoxPopuli-ai-agent wants to merge 4 commits into
Closed
NullVoxPopuli-ai-agent wants to merge 4 commits into
NullVoxPopuli-ai-agent wants to merge 4 commits into
Conversation
A PR that changes only packages/@glimmer/syntax/test does not change the published package, so it must not cause a release or need a label. The release-plan "files" option leaves the test folder out of the git history that release-plan reads for this package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tsconfig.json in @glimmer/component and .npmignore in @glimmer/syntax are tooling config. A PR that changes only one of them must not cause a release or need a label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NullVoxPopuli-ai-agent
changed the title
Each package now names the files that its build reads: index.ts and lib/** for @glimmer/syntax, src/** and addon-main.cjs for @glimmer/component. A new test or config file then does not need a new exclude. release-plan always counts the package.json too. Git globs have no brace expansion, so the folders are separate globs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NullVoxPopuli-ai-agent
changed the title
A root index file is the entry of a package, whether the package uses one today or adds one later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by #21734, which combines this change with the release-plan 0.22.0 upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
release-planfilesconfig to the two packages that release-plan publishes. Each config lists the files that the build of the package reads:files@glimmer/syntax["index.js", "index.ts", "lib/**"]@glimmer/component["index.js", "index.ts", "src/**", "addon-main.cjs"]Only changes to these files, and to the
package.jsonof the package, count. So a PR that changes only tests, config files, or docs in a package folder does not cause a release, and it does not need a label.A root
index.jsorindex.tsis the entry of a package. Today only@glimmer/syntaxhas one,index.ts, which is its rollup entry.addon-main.cjsis the v1 addon shim that@glimmer/componentpublishes.Git globs have no brace expansion, so
{src,lib}/**andindex.{js,ts}match nothing. Each path needs its own glob.Needs a new release-plan version
The
filesoption is in NullVoxPopuli/release-plan#13, which merged after 0.21.0. Until a new version is published and this repo updates to it, release-plan ignores the key, and nothing changes.Local check
I ran
gather-changeswith a build of the fork'snextbranch. Compared with 0.21.0, the only PR that dropped out is #21317, which changed only files inpackages/@glimmer/syntax/test/.🤖 Generated with Claude Code