Repository navigation
[CLEANUP] Use native classes in the positional args component manager tests - #21765
Merged
NullVoxPopuli merged 1 commit intoOct 23, 2026
Conversation
The four positional args tests in custom-component-manager-test.js now use a native component class with a native custom manager, not EmberObject and factory.create(). The two "(computed, ...)" tests keep @computed, because the dependent keys on args.positional are what they test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NullVoxPopuli
marked this pull request as ready for review
October 21, 2026 18:51
bertdeblock
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four positional argument tests in
custom-component-manager-test.jsnow use a native class with a native component manager. Before, they usedEmberObjectandfactory.create().These four tests are the only component tests outside the classic
Componentthat readargs.positional. With this change, they do not depend onEmberObject(#21674).What changes
NativeComponentManager(capabilities3.13,new ComponentClass(args)) and aNativeComponentbase class with that manager.NativeComponent:@computed, because they test the dependent keys onargs.positional.The other tests in the file still use
EmberObject. This PR does not change them.Verified locally
The "Component Manager" modules pass in development (24 tests), with
ALL_DEPRECATIONS_ENABLED=true(24) and in production (23).🤖 Generated with Claude Code