Skip to content

Remove unused FS.filesystems property from libfs.js. NFC - #27918

Closed
sbc100 wants to merge 1 commit into
mainfrom
ai_cleanup_fs_filesystems
Closed

sbc100 wants to merge 1 commit into
mainfrom
ai_cleanup_fs_filesystems

Conversation

@sbc100

@sbc100 sbc100 commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@sbc100
sbc100 requested a review from kripken October 7, 2026 20:38
Comment thread src/lib/libfs.js
#if FS_DEBUG
trackingDelegate: {},
#endif
filesystems: null,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is used on line 1586,

FS.filesystems = {

So this null is basically a placeholder for that, to avoid mutating the object shape.

Though I guess that code is dead? If so let's remove it too?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I guess AI was just wrong about this one.

1 out of 14 cleanup PRs is not bad though.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it wasn't wrong, just not thorough enough in removing dead code (and, in this case, that means a small performance downside).

@sbc100 sbc100 closed this Oct 7, 2026
@sbc100
sbc100 deleted the ai_cleanup_fs_filesystems branch October 7, 2026 21:45
kripken added a commit that referenced this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants