Repository navigation
Conversation
After llvm/llvm-project#232977 removed TargetOptions::ExceptionModel, passing -mllvm -exception-model=... to wasm-ld is a no-op. All WebAssembly EH and SjLj passes now read the "exception-model" module flag emitted into the IR by clang at compile time.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the logic in tools/building.py that appends -exception-model flags (such as wasm or emscripten) to the linker flags (lld_flags) based on exception and longjmp settings. I have no feedback to provide as there are no review comments.
Member
Author
|
This should wait to land until the aforementioned PR rolls into emscripten-releases and then back into Emscripten's emsdk_version.txt. Since the flags are a no-op, nothing should break when that happens. |
Collaborator
|
Sweet! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After llvm/llvm-project#232977 removed TargetOptions::ExceptionModel, passing -mllvm -exception-model=... to wasm-ld is a no-op. All WebAssembly EH and SjLj passes now read the "exception-model" module flag emitted into the IR by clang at compile time.