Repository navigation
Conversation
…ions Copy actions and map HEAD at as_view() creation time rather than mutating the actions dictionary during request dispatch. This ensures the caller's actions dictionary is not mutated in-place and view.actions is deterministic both before and after requests are handled. Fixes encode#9747
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9747
Description
In \ViewSetMixin.as_view(), the \�ctions\ dictionary passed into the method was captured by the inner \�iew(request, *args, **kwargs)\ closure without being copied. During request dispatch, the block:
\\python
if 'get' in actions and 'head' not in actions:
actions['head'] = actions['get']
\
mutated the \�ctions\ dictionary in-place. This caused two problems:
Solution
Testing