Repository navigation
[6.x] Default "env" to production and stop reading NODE_ENV - #7549
Open
UlisesGascon wants to merge 1 commit into
Open
UlisesGascon wants to merge 1 commit into
UlisesGascon wants to merge 1 commit into
Conversation
BREAKING CHANGE: the "env" setting no longer derives from NODE_ENV and
defaults to "production". The default error handler never exposes error
details and "view cache" is enabled unless the app opts into development
with app.set('env', 'development').
Member
Author
|
If we agree on this approach... then I can prepare a deprecation warning for express@5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
envsetting is no longer derived fromNODE_ENVand now defaults toproduction, so the safe behavior is the default: the default error handler never includes error details in responses andview cacheis enabled. Setapp.set('env', 'development')to get the previous development behavior, or setview cachedirectlyNotes for reviewers
NODE_ENV=test.test/support/env.jsnow defaults every app toenv: testby wrappingdefaultConfiguration, which keeps error details in test responses and the default logger quiet. Explicitapp.set('env', 'test')calls in the affected tests would be the alternative.