Skip to content

Show the selected marker of a loaded URL in profiler-cli status - #6448

Open
fatadel wants to merge 1 commit into
firefox-devtools:mainfrom
fatadel:claude/profiler-cli-feedback-check-e1fc7d
Open

fatadel wants to merge 1 commit into
firefox-devtools:mainfrom
fatadel:claude/profiler-cli-feedback-check-e1fc7d

Conversation

@fatadel

@fatadel fatadel commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Main | Deploy preview

A profiler.firefox.com URL selects a marker with marker=N. Loading such a URL kept the selection, but no command reported which marker it was. load and status now print the selected thread's selected marker with its handle, and status --json has it as selectedMarker.

The status result has no session context, so createTimestampFormatter takes only the view range and root range that it reads.

Closes #6446

A profiler.firefox.com URL selects a marker with `marker=N`. Loading
such a URL kept the selection, but no command reported which marker it
was. `load` and `status` now print the selected thread's selected
marker with its handle, and `status --json` has it as `selectedMarker`.

The status result has no session context, so createTimestampFormatter
takes only the view range and root range that it reads.
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.96%. Comparing base (db1f1d3) to head (765e081).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-query/index.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6448      +/-   ##
==========================================
+ Coverage   84.95%   84.96%   +0.01%     
==========================================
  Files         359      359              
  Lines       39137    39181      +44     
  Branches    11096    11004      -92     
==========================================
+ Hits        33249    33291      +42     
- Misses       5451     5453       +2     
  Partials      437      437              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel
fatadel requested review from canova and mstange November 10, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A link's marker=N can't be mapped to a marker handle in profiler-cli

1 participant