Repository navigation
Conversation
A profiler.firefox.com URL selects a marker with `marker=N`. Loading such a URL kept the selection, but no command reported which marker it was. `load` and `status` now print the selected thread's selected marker with its handle, and `status --json` has it as `selectedMarker`. The status result has no session context, so createTimestampFormatter takes only the view range and root range that it reads.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6448 +/- ##
==========================================
+ Coverage 84.95% 84.96% +0.01%
==========================================
Files 359 359
Lines 39137 39181 +44
Branches 11096 11004 -92
==========================================
+ Hits 33249 33291 +42
- Misses 5451 5453 +2
Partials 437 437 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
A profiler.firefox.com URL selects a marker with
marker=N. Loading such a URL kept the selection, but no command reported which marker it was.loadandstatusnow print the selected thread's selected marker with its handle, andstatus --jsonhas it asselectedMarker.The status result has no session context, so createTimestampFormatter takes only the view range and root range that it reads.
Closes #6446