Repository navigation
Conversation
The shifting of the timestamps of one marker payload is its own exported function, so that it can be used without a raw marker table. It replaces a shifted `cause` with a copy instead of changing the object that the input payload also points to. The returned payloads are the same as before, and the existing tests pass unchanged.
Marker starts and ends, stack capture times and the counter sample range were already milliseconds since the profile start, but the other times in --json output were raw profile timestamps, offset from those by rootRange.start. View ranges and zoom results, counter buckets, thread and process lifetimes, CPU activity slices, network request starts and the page load navigation start now use the same base. rootRange stays raw. The timestamps inside a marker's payload are rebased in `data` and in `fields[].value` too. They are shifted with adjustMarkerPayloadTimestamps, plus the timestamps that marker derivation adds to IPC and Network payloads. Text output is unchanged.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6459 +/- ##
==========================================
+ Coverage 84.97% 85.00% +0.03%
==========================================
Files 359 362 +3
Lines 39170 39680 +510
Branches 11115 11179 +64
==========================================
+ Hits 33284 33731 +447
- Misses 5449 5510 +61
- Partials 437 439 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Some times in
--jsonoutput were milliseconds since the profile start and others were raw profile timestamps. Now all of them are relative to the profile start, and onlyrootRangestays raw.This covers view ranges and zoom results, counter buckets, thread and process lifetimes, CPU activity slices, network request starts, the page load navigation start, and the timestamps inside marker payloads (
dataandfields[].value).The first commit extracts
adjustMarkerPayloadTimestampsfromadjustMarkerTimestamps, so the CLI shifts payload timestamps with the same code that profile merging uses.Closes #6458