Skip to content

Show Log marker fields that hold a string instead of a string index - #6461

Open
fatadel wants to merge 1 commit into
firefox-devtools:mainfrom
fatadel:profiler-cli-log-marker-strings
Open

fatadel wants to merge 1 commit into
firefox-devtools:mainfrom
fatadel:profiler-cli-log-marker-strings

Conversation

@fatadel

@fatadel fatadel commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Main | Deploy preview

The Log marker schema declares level and message as unique-string, but Firefox's test harness writes plain strings into these fields. The formatter looked the string up in the string table as an index, so profiler-cli and the marker tooltip showed (empty) for the level and the message of a test's info() lines.

A string in a unique-string, flow-id or terminating-flow-id field is now shown as is.

Closes #6460

The Log marker schema declares `level` and `message` as unique-string,
but Firefox's test harness writes plain strings into these fields. The
formatter looked the string up in the string table as an index, so
profiler-cli and the marker tooltip showed "(empty)" for the level and
the message of a test's info() lines.

A string in a unique-string, flow-id or terminating-flow-id field is
now shown as is.
@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.98%. Comparing base (68f63c0) to head (24dda3e).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6461      +/-   ##
==========================================
+ Coverage   84.97%   84.98%   +0.01%     
==========================================
  Files         359      362       +3     
  Lines       39170    39667     +497     
  Branches    11115    11177      +62     
==========================================
+ Hits        33284    33711     +427     
- Misses       5449     5517      +68     
- Partials      437      439       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel
fatadel requested review from canova and mstange and removed request for canova November 13, 2026 14:52
@fatadel
fatadel marked this pull request as ready for review November 13, 2026 14:52
@fatadel
fatadel requested a review from canova November 13, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

profiler-cli prints "(empty)" for the level and message of test Log markers

1 participant