Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authenticated requests can currently save classroom names and descriptions beyond the limits enforced by the form. Both create and edit now return HTTP 400 for invalid text before writing to the database, using the same 100-character name and 500-character description limits as the modal.
The limits live in a shared utility. Creation requires a nonempty string name; partial edits still allow omitted fields, and descriptions remain optional and nullable. Existing authentication and teacher ownership checks remain in place.
Validation:
pnpm run lintpassed (existing repository warnings remain).pnpm test: 355 tests passed.pnpm run build --webpackpassed.Related to #640, section 2: classroom name and description validation. This PR addresses that item only.
Checklist:
main.pnpm run lintandpnpm testlocally.pnpm run develop --webpack.AI assistance was used for implementation and review; all checks listed above were run locally.