Repository navigation
fix(dashboard): Keep the header the same width on every page - #2151
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Richard Roggenkemper <richard.roggenkemper@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
This fixes the jump between Conversations and Code, but the secondary navigation strip is now out of line with the header.
The desktop strip in SecondaryNavigation (System, Automations, Memories, Code repository pages) still uses dashboardContainerClass with md:px-8. Before this PR it used the same frame as the header, so the two rows lined up. Now the primary nav sits at the left edge and the sub-tabs (Overview / People / Locations / …) start about 230px to the right of it at 1728px wide. Users will see a new misalignment on each page that has sub-tabs.
Fix: give the desktop strip in SecondaryNavigation.tsx the same full-width frame as the header (w-full min-w-0 px-4 py-2 md:px-7). Then the sub-tabs line up under the primary nav, and page content keeps its centered width. The rest of the change looks right. Removing compact is clean, and the mobile classes did not change.
|
54 screenshot changes — 54 changed · 0 added · 0 removed Review screenshots in Frameshift Show 12 more changed screenshots36 more changed screenshots in Frameshift. |
Co-Authored-By: Richard Roggenkemper <richard.roggenkemper@sentry.io>
The primary nav jumped when you moved between Conversations and other pages. The Conversations workspace rendered the header full width (
compact), while Code, Automations, Memories, and System put it in the centeredmax-w-screen-xlcontainer with different padding. The logo, nav links, and spend/profile control all moved on each route change.The header now uses one full-width frame with the same padding on every route, so the nav stays in place. I removed the
compactprop because nothing else needs it. Page content keeps its current centered width.via richard.
--
View Junior Session [Sentry]