Repository navigation
fix: keep all values of repeated keys in urlencoded_params_matcher - #829
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
The request body was parsed with dict(parse_qsl(...)), so only the last
value of a repeated key survived: a request with data={"id": ["1", "2"]}
matched urlencoded_params_matcher({"id": "2"}) and could not be matched
with a list at all. Repeated keys are now collected into a list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request body was parsed with dict(parse_qsl(...)), so only the last value of a repeated key survived: a request with data={"id": ["1", "2"]} matched urlencoded_params_matcher({"id": "2"}) and could not be matched with a list at all. Repeated keys are now collected into a list.
What type of PR is this? (check all applicable)
Description
Related Issues
PR checklist
Before submitting this pull request, I have done the following:
toxandpre-commitchecks locallyAdded/updated tests?