Repository navigation
feat: Enable consoleLoggingIntegration by default in node, bun, cloudflare, and vercel-edge sdks - #17747
Closed
AbhiPrasad wants to merge 7 commits into
Closed
feat: Enable consoleLoggingIntegration by default in node, bun, cloudflare, and vercel-edge sdks#17747AbhiPrasad wants to merge 7 commits into
consoleLoggingIntegration by default in node, bun, cloudflare, and vercel-edge sdks#17747AbhiPrasad wants to merge 7 commits into
Conversation
AbhiPrasad
requested review from
chargome and
stephanie-anderson
and removed request for
a team
September 23, 2025 18:32
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
size-limit report 📦
|
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
approved these changes
Sep 24, 2025
Comment on lines
+55
to
+58
| if (options.enableLogs) { | ||
| // TODO(v11): Remove this once we add logs to the `consoleIntegration`. | ||
| integrations.push(consoleLoggingIntegration()); | ||
| } |
Member
There was a problem hiding this comment.
no action required: Not sure if it makes sense to unify consoleIntegration and consoleLoggingIntegration. Probably depends on our plan for breadcrumbs going forward but I kinda like smaller single-purpose integrations over larger ones.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AbhiPrasad
enabled auto-merge (squash)
September 24, 2025 23:59
chargome
approved these changes
Oct 3, 2025
stephanie-anderson
removed their request for review
October 13, 2025 15:21
auto-merge was automatically disabled
January 12, 2026 20:21
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the console logging integration by default in node, bun, cloudflare, and vercel-edge sdks. By enabling it in the node sdk, we also enable it in the aws serverless and google cloud function sdks.
In v11 we can refactor this as we'll use the
consoleIntegrationto handle this. See #17702 for more details.