Repository navigation
ref(client): Put org_id resolution in the Client - #1326
Open
szokeasaurusrex wants to merge 1 commit into
Open
szokeasaurusrex wants to merge 1 commit into
szokeasaurusrex wants to merge 1 commit into
Conversation
Centralize the logic for determining `org_id` on the `Client`; previously, it was living in the `performance` module as we use it there to determine org ID for strict trace continuation. This change also includes an optimization of storing the resolved `org_id` on the `Client`; previously every continued incoming trace resulted in a re-parsing of the DSN's host when no explicit `org_id` was set. This change will allow us to more easily access the `org_id` elsewhere we may need it.
szokeasaurusrex
added this pull request to stack #1332
September 22, 2026 13:39
szokeasaurusrex
marked this pull request as ready for review
September 22, 2026 13:41
giortzisg
approved these changes
Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize the logic for determining
org_idon theClient; previously, it was living in theperformancemodule as we use it there to determine org ID for strict trace continuation.This change also includes an optimization of storing the resolved
org_idon theClient; previously every continued incoming trace resulted in a re-parsing of the DSN's host when no explicitorg_idwas set.This change will allow us to more easily access the
org_idelsewhere we may need it.