Repository navigation
Conversation
timfish
marked this pull request as ready for review
October 22, 2026 11:51
szokeasaurusrex
approved these changes
Oct 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 73.81% 74.33% +0.52%
==========================================
Files 64 79 +15
Lines 7538 10044 +2506
==========================================
+ Hits 5564 7466 +1902
- Misses 1974 2578 +604 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, the system crash handler was displayed even when we successfully capture and send the minidump. This is in contrast to the Windows behaviour where WER is skipped when successful. This change brings the macOS behaviour in line with Windows, Breakpad and Crashpad.