Skip to content

[lint-monster] Handle ignored errors and discarded results #68572

Open

Description

@github-actions

Daily custom lint findings

The 2026-10-16 scan reported 891 ignored-result findings across 165 files. Scan run: §38841529624.

Representative diagnostics

  • pkg/console/spinner.go:208:4: assignment with two blank identifiers discards every result.
  • pkg/parser/frontmatter_content.go:260:2: scanner loop does not check Err() after completion, so read errors may be dropped.
  • pkg/cli/edit_command.go:154:7: the Close() error is explicitly discarded.
  • pkg/console/confirm.go:60:2: the error from fmt.Fprintf() is not checked.

Affected paths

Highest-count examples from the scan:

  • pkg/workflow/drive_memory.go (74)
  • pkg/workflow/cache_memory.go (60)
  • pkg/workflow/compiler_yaml_step_lifecycle.go (38)
  • pkg/workflow/jobs.go (27)
  • pkg/workflow/checkout_step_generator.go (23)

Remediation checklist

  • Address only unchecked or ignored errors and discarded return or type-assertion results in this category.
  • Handle each result according to its operation: propagate or report meaningful failures, check scanner errors after iteration, and handle cleanup errors without hiding the primary error.
  • Use a single-value type assertion only when a failed assertion is safe for the operation; otherwise check and handle the ok result.
  • Keep edits minimal, preserve behavior, and do not suppress findings or change linter rules.
  • Run make golint-custom to validate the fixes.

Generated by 🧌 LintMonster · codex · gpt60 · 2.94 AIC · ⌖ 0.316 AIC · ⊞ 16K · ◷

Generated by 🧌 LintMonster · codex · gpt60 · 2.6 AIC · ⌖ 0.326 AIC · ⊞ 16.4K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions