Repository navigation
no-async-foreach-callback: computed-property calls and named async-function references bypass detection (false negative) #69217
Description
Summary
no-async-foreach-callback (eslint-factory/src/rules/no-async-foreach-callback.ts) exists specifically to catch the classic forEach()-with-async-callback bug (discarded promise, unawaited work, unhandled rejections). The test fixture lists two forms as explicitly valid (unflagged) that belong to the same bug class the rule targets:
- Computed-property access:
items["forEach"](async x => {})is valid today purely because the rule bails out atcallee.computedwith no further check -- no scope analysis needed, this is a pure AST-shape gap. This codebase already treats bracket-notation access as an equivalent form worth covering in several sibling rules (for exampleJSON["parse"],err["message"]). - Named function reference:
items.forEach(handler)is valid today because the rule only inspects the callback argument node itself for.async === true; it never resolveshandlerback to its declaration. Ifhandleris declared asasync function handler(x) { await f(x); }(orconst handler = async x => {...}) and passed by reference, the same discarded-promise bug occurs and goes undetected.
Where
eslint-factory/src/rules/no-async-foreach-callback.ts, the CallExpression visitor: the callee.computed early return, and the callback-shape check that only accepts an inline ArrowFunctionExpression/FunctionExpression with .async === true.
Confirmed via the valid-test fixtures in no-async-foreach-callback.test.ts: items["forEach"](async x => {}); and items.forEach(handler); are both listed under valid.
Reproduction (constructed)
Case 1 (computed access):
items["forEach"](async (x) => { await process(x); }); // NOT flagged today
Case 2 (named reference):
async function handleItem(x) { await process(x); }
items.forEach(handleItem); // NOT flagged today
Acceptance criteria
- Drop the
callee.computedearly return in favor of also accepting a computed, string-literalforEachproperty name (mirroring the non-computed case), consistent with how other rules in this factory already handle bracket-notation access. - When the callback argument is a plain Identifier, resolve it to its binding (function declaration, or a write-once const bound to a function/arrow expression) using a write-once scope walk consistent with this factory conventions (for example try-catch-rule-utils.ts), and flag it when the resolved function is async. Leave genuinely unresolvable references (parameters, reassigned bindings, imports) out of scope, matching this factory established convention.
- Add invalid tests for both forms above, and keep (or add) a valid test for a non-async named function reference (e.g. items.forEach(syncHandler)) and an unresolvable reference (e.g. a function parameter) to confirm no new false positives.
Scope
eslint-factory/** only.
Filed by ESLint Refiner (daily run 2026-10-16).
Generated by 🤖 ESLint Refiner · claude · agent · 161.5 AIC · ⌖ 0.878 AIC · ⊞ 5.3K · ◷
- expires on Oct 22, 2026, 7:43 PM UTC-08:00
Activity
github-actions commentedon Oct 16, 2026
🍪 Issue Monster selected this for Copilot
I identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 16, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 16, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 17, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 17, 2026
🍪 Issue Monster selected this for Copilot
I identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 17, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 17, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 17, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 17, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
This issue is a good candidate for automated resolution and has been requested for the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 18, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 19, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 19, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 19, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 19, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪
github-actions commentedon Oct 19, 2026
🍪 Issue Monster selected this for Copilot
I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.
If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.
Om nom nom! 🍪