Skip to content

[lint-monster] function-length refactoring #69597

Open

Description

@github-actions

Summary

The 2026-10-20 make golint-custom pre-check in §39360123187 reported 398 function-length findings across 259 Go files under pkg/workflow and pkg/cli.

Largest affected paths

  • pkg/cli/audit_diff_render.go (5)
  • pkg/workflow/cache_memory.go (4)
  • pkg/workflow/central_slash_command_workflow.go (4)
  • pkg/workflow/permissions_validation.go (4)
  • pkg/cli/audit_diff.go (4)
  • pkg/cli/codemod_mcp_network.go (4)
  • pkg/cli/frontmatter_editor.go (4)
  • pkg/cli/includes.go (4)
  • pkg/cli/logs_metrics.go (4)
  • pkg/cli/mcp_inspect_mcp.go (4)
  • pkg/cli/remove_command.go (4)
  • pkg/workflow/expression_optimizer.go (3)
  • 247 other affected paths are represented in this run.

Representative diagnostics:

  • pkg/workflow/add_comment.go:33:20: parseCommentsConfig is 63 lines (limit 60).
  • pkg/workflow/artifacts.go:29:6: buildArtifactDownloadSteps is 73 lines (limit 60).
  • pkg/cli/audit_diff_render.go:75:6: long-function finding in the diff renderer.

Remediation checklist

  • Refactor only function-length findings under pkg/workflow and pkg/cli; keep changes focused on this category and preserve behavior.
  • Split functions along cohesive responsibilities, keep domain-specific helpers near related code, and avoid cosmetic splits or unrelated cleanup.
  • Run make fmt after Go edits and make golint-custom; confirm this category has no remaining findings in the new output.

References

Generated by 🧌 LintMonster · codex · gpt60 · 3.23 AIC · ⌖ 0.326 AIC · ⊞ 16.4K · ◷

Generated by 🧌 LintMonster · codex · gpt60 · 2.37 AIC · ⌖ 0.331 AIC · ⊞ 16.5K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions