Skip to content

[avenger] Fix CLI tester expected-exclusion policy assertion #69945

Closed as not planned

Description

@github-actions

CI failure and fix

CI run 39139738137, job Integration: Workflow Misc Part 2, failed in TestDailyCLIToolsTesterCompileEdgeCasePolicy. The test still required report_incomplete for intentionally excluded synthetic compile cases, but the workflow now explicitly reports those cases as expected exclusions in a findings issue or final noop.

Update the test to assert the current reporting contract and reject the obsolete instruction. Preserve assertions forbidding synthetic fixtures and overstated compile coverage. Only one Go test file changed; no files under .github/workflows/ are included.

Validation

  • Passed: make fmt.
  • Passed: go test -tags integration ./pkg/workflow -run '^TestDailyCLIToolsTesterCompileEdgeCasePolicy$' -count=1.
  • Passed: make test-unit invoked once by the final validation gate (five sampled workflow-package tests), build, schema freshness, and change-scoped custom Go lint checks.
  • Passed: git diff --check; committed worktree is clean.
  • make agent-report-progress did not pass overall because golangci-lint is not installed. No installation was attempted, and full make lint is not claimed to pass.

Environment limitations

git fetch origin main failed certificate verification, so refreshing and merging the latest remote main was not possible. TLS settings were not changed; the fix uses the supplied checkout at a84462a. No workflow source differences against the available origin/main were found, so recompilation was skipped. No valid steering issue number was supplied, preventing a steering-comments lookup. The unavailable report_progress tool was reported; publication uses the configured safe-output PR path instead.

Avenger run 3104; commit 42bc0f3.


Note

This was originally intended as a pull request, but the git push operation failed.

Original error: ERR_SYSTEM: pushSignedCommits: failed to rebase commit range onto current GraphQL parent (eb42b26). Resolve conflicts by rebasing/cherry-picking locally and retry. Root cause: Auto-merging pkg/workflow/daily_cli_tools_tester_policy_test.go CONFLICT (content): Merge conflict in pkg/workflow/daily_cli_tools_tester_policy_test.go Rebasing (1/1) error: could not apply 9d617a2... Fix CLI tester expected-exclusion policy assertion hint: Resolve all conflicts manually, mark them as resolved with hint: "git add/rm (conflicted_files)", then run "git rebase --continue". hint: You can instead skip this commit: run "git rebase --skip". hint: To abort and get back to the state before "git rebase", run "git rebase --abort". hint: Disable this message with "git config set advice.mergeConflict false" Could not apply 9d617a2... # Fix CLI tester expected-exclusion policy assertion

Workflow Run: View run details and download bundle artifact

The bundle file is available in the agent artifact in the workflow run linked above.

Create the pull request manually
# Download the artifact from the workflow run
gh run download '39140801302' -n agent -D '/tmp/agent-39140801302'

# Resolve the bundle source ref, fetch it into a temporary ref, then create the local branch
bundle_path='/tmp/agent-39140801302/aw-github-gh-aw-avenger-fix-cli-tester-policy-39140801302.bundle'
temp_ref='refs/bundles/create-pr-avenger-fix-cli-tester-policy-39140801302-c8a53ef6ea5a107d-8e52fcf3'
target_ref='refs/heads/avenger/fix-cli-tester-policy-39140801302-c8a53ef6ea5a107d'
bundle_source_ref=$(git bundle list-heads "$bundle_path" | awk '$2 ~ /^refs\/heads\// { print $2 }')
if [ -z "$bundle_source_ref" ]; then
  bundle_source_ref=$(git bundle list-heads "$bundle_path" | awk '$2 == "HEAD" { print $2 }')
fi
if [ "$(printf '%s\n' "$bundle_source_ref" | sed '/^$/d' | wc -l | tr -d ' ')" != "1" ]; then
  echo "Expected exactly one bundle source ref, found: $bundle_source_ref" >&2
  exit 1
fi
git fetch "$bundle_path" "${bundle_source_ref}:${temp_ref}"
git update-ref "$target_ref" "$temp_ref"
git checkout 'avenger/fix-cli-tester-policy-39140801302-c8a53ef6ea5a107d'
# Ensure the working tree matches the updated branch
git reset --hard
# Remove the temporary bundle ref
git update-ref -d "$temp_ref"

# Push the branch to the target remote
git push 'origin' 'avenger/fix-cli-tester-policy-39140801302-c8a53ef6ea5a107d'

# Create the pull request
gh pr create --title '[avenger] Fix CLI tester expected-exclusion policy assertion' --base 'main' --head 'avenger/fix-cli-tester-policy-39140801302-c8a53ef6ea5a107d' --repo 'github/gh-aw'

Generated by 🦸 Avenger · copilot · gpt60 · 112.1 AIC · ⌖ 70.9 AIC · ⊞ 20.7K · ◷

  • expires on Oct 20, 2026, 7:42 AM UTC-08:00

Activity

  1. github-actions commented on Oct 20, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-10-20T15:42:44.361Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions