Repository navigation
fix(eslint-miner): allow scoped rule README updates - #70441
Conversation
Exempt only eslint-factory/README.md from protected-file fallback so ordinary rule documentation can produce independently verifiable PR delivery. Preserve all other file protections and regenerate embedded worker contract hashes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🔍 Design Decision Gate 🏗️ is checking for design decision records on this pull request... |
|
🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills... |
|
🔎 PR Code Quality Reviewer is reviewing code quality for this pull request... |
|
🔬 Test Quality Sentinel is analyzing test quality on this pull request... |
|
✂️ Ponytail Reviewer has started processing this pull request |
There was a problem hiding this comment.
🔵 Needs a closer look
The protected-file exception changes an autonomous agent’s write controls and warrants maintainer security sign-off.
No open issues 🎉
What changed in this PR
Allows ESLint Miner’s rule README updates to produce pull requests rather than review issues, while preserving directory restrictions and Claim-delivery verification.
Changes:
- Exempt only
/eslint-factory/README.mdfrom protected-file fallback. - Refresh compiled settings and dispatcher contract references.
- Test both compiled configurations and patch/post-apply protection checks.
| File | Description |
|---|---|
actions/setup/js/eslint_factory_portfolio.test.cjs |
Adds scoped protection regression coverage. |
.github/workflows/eslint-miner.md |
Declares the exact README exception. |
.github/workflows/eslint-miner.lock.yml |
Updates compiled protections and contract hash. |
.github/workflows/eslint-factory-dispatcher.lock.yml |
Refreshes miner contract references. |
Review effort: Max
|
🎉 This pull request is included in a new release. Release: |
Summary
ESLint Miner's rule documentation changed
eslint-factory/README.md, triggering basename-based protected-file fallback in run 39364978477. The handler created review issue #70421 instead of a PR, so independent Claim verification correctly refused to publish a Result.Exempt only the exact path
/eslint-factory/README.mdfrom protected-file fallback while retainingallowed-files: eslint-factory/**and all other protections. Claim-delivery verification is unchanged.Regenerate the miner lock and the three dispatcher locks that embed its updated contract hash. Add regression coverage for both compiled agent/handler configurations and both patch/post-apply checks: the intended README is allowed, other protected files still fall back, and out-of-scope files remain denied.
Validation
npm run typecheck --silentinactions/setup/js.make fmt-cjsandmake lint-cjs.make recompileand scoped./gh-aw compile eslint-miner --validate --no-check-update.make agent-report-progress, including workflow lock drift checks.This is a prospective correction. No workflow was dispatched or rerun, and the original failed Claim was not retried, reconciled, or modified. Review-issue creation is not treated as verified PR delivery.