Repository navigation
Fix CI assertions and troubleshooting guidance for admission gate - #70585
Conversation
Parse activation job conditions from YAML so admission guards and folded formatting preserve the existing regression coverage. Document ERR_ADMISSION within the debug playbook consumption budget. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🔍 Design Decision Gate 🏗️ is checking for design decision records on this pull request... |
|
🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills... |
|
🔎 PR Code Quality Reviewer is reviewing code quality for this pull request... |
|
✂️ Ponytail Reviewer has started processing this pull request |
|
🔬 Test Quality Sentinel is analyzing test quality on this pull request... |
There was a problem hiding this comment.
🟢 Approval recommended
The focused test and documentation changes match existing admission behavior, with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
Aligns gh-aw regression tests and troubleshooting guidance with the existing admission gate. Runtime behavior is unchanged.
Changes:
- Parse compiled YAML to verify workflow conditions, admission guards, and dispatcher dependencies.
- Add
ERR_ADMISSIONtroubleshooting guidance while retaining the playbook’s word limit.
| File | Description |
|---|---|
pkg/workflow/task_job_generation_fix_test.go |
Check activation conditions using parsed YAML. |
actions/setup/js/daily_report_portfolio.test.cjs |
Verify dispatcher conditions and admission dependency structurally. |
.github/aw/debug-playbook.md |
Add admission error troubleshooting guidance. |
Review effort: Max
|
🎉 This pull request is included in a new release. Release: |
The admission gate introduced in #70429 left CI and CJS failing because two regression tests assumed single-line job conditions and the diagnostic playbook did not cover
ERR_ADMISSION.Parse the compiled YAML and inspect the activation job's condition instead of matching its serialized formatting. Preserve checks for the original workflow condition and the admission result guard, and verify the dispatcher's admission dependency. Add admission troubleshooting guidance while retaining the playbook's 2,800-word limit.
No runtime behavior or workflow sources are changed.
Validation
make test-guidancego test -tags integration ./pkg/workflow -run '^TestTaskJobGenerationFix$' -count=1make build && make fmtmake lint-cjsmake agent-report-progress, including impacted tests and workflow drift checks